src: make StreamBase::GetAsyncWrap pure virtual #13174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
addaleax
added
the
lib / src
jasnell
approved these changes
May 23, 2017
cjihrig
approved these changes
May 23, 2017
danbev
approved these changes
May 24, 2017
2 tasks
|
Landed in 169c07d |
addaleax
added a commit
that referenced
this pull request
May 25, 2017
PR-URL: #13174 Reviewed-By: Andreas Madsen <amwebdk@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
May 25, 2017
PR-URL: #13174 Reviewed-By: Andreas Madsen <amwebdk@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
May 28, 2017
PR-URL: #13174 Reviewed-By: Andreas Madsen <amwebdk@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
3 tasks
MylesBorins
added
the
baking-for-lts
|
@addaleax should we land this now or wait for a larger async_hooks update? |
addaleax
removed
the
baking-for-lts
|
@MylesBorins This is not the kind of change that would be harmful to include, or that would need to bake for any significant time. If it compiles, include it. :) |
|
@addaleax it does not land cleanly, I don't think the async_wrap stuff has been backported |
|
ping re: backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting out from #13142, this is a bit that should be easy to review. (All remaining
GetAsyncWrapmethods never returnnullptr.)Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)